[linux-dvb] I2C Bus probing was Re: (temp. solution) modprobe mantis stalls/hangs/freezes (Twinhan VP-1034 and ivtv)

Michael Krufky mkrufky at linuxtv.org
Sun Aug 26 19:06:56 CEST 2007


Manu Abraham wrote:
> Michael Krufky wrote:
>
>   
>> Manu,
>>
>> You can go on and on about how probing is wrong -- I already agree with you in that respect.  Regardless, the saa7115 driver does this probe, and this will not change until after the new i2c methods are implemented in the video decoder i2c_client modules.
>>
>> I haven't looked at the Mantis code, but...  if you don't need to use any of the preexisting i2c client modules that attach via probing, then just remove I2C_CLASS_TV_DIGITAL from the i2c_adapter->class from within the Mantis driver.  This will prevent any probes from occurring on your device.
>>
>>     
>
> Seems like you've taken it on a personal level.
>
>   
There was nothing personal in what I've written -- I am simply trying to
explain something.
> There's nothing wrong with the Mantis.
> Folks have become more used to fixing the working devices, rather than
> fixing the broken ones.
You can disable probes in the Mantis driver, using the recommendation
that I made above!!!

I'm not saying that anything is wrong with Mantis -- I am merely stating
that since Mantis doesn't use probed i2c clients, that Mantis should
simply disallow such probing.


What can be simpler than that?

-Mike



More information about the linux-dvb mailing list