[linux-dvb] [PATCH] mt312: coding style improvements

Matthias Schwarzott zzam at gentoo.org
Thu Dec 20 23:37:47 CET 2007


On Donnerstag, 20. Dezember 2007, Andreas Oberritter wrote:
> Matthias Schwarzott wrote:
> > Changing mt312 driver today.
> >
> > The first patch improves codingstyle - I did fix almost all things
> > checkpatch lists.


> > I did not change if ((ret = func(a)) < 0) {
> >

Btw. what do you think about this coding pattern?

Should that also be changed to (as checkpatch suggests):
ret = func(a);
if (ret < 0) {

As the first form seems to be used in very many lines and different drivers.

Matthias

-- 
Matthias Schwarzott (zzam)



More information about the linux-dvb mailing list