[linux-dvb] szap sets FE_DISEQC_SEND_BURST incorrectly

Reinhard Nissl rnissl at gmx.de
Thu Feb 1 23:51:09 CET 2007


Hi,

I'm not sure whether this is the right place to report an issue
regarding szap, so please be so kind and point me to the proper place in
case I'm wrong.

Please have a look into szap.c, function diseqc(). There is this
function call:

   diseqc_send_msg(secfd, pol_vert ? SEC_VOLTAGE_13 : SEC_VOLTAGE_18,
                   &cmd, hi_band ? SEC_TONE_ON : SEC_TONE_OFF,
                   (sat_no / 4) % 2 ? SEC_MINI_B : SEC_MINI_A);

I think it should read:

   diseqc_send_msg(secfd, pol_vert ? SEC_VOLTAGE_13 : SEC_VOLTAGE_18,
                   &cmd, hi_band ? SEC_TONE_ON : SEC_TONE_OFF,
                   sat_no % 2 ? SEC_MINI_B : SEC_MINI_A);

As sat_no will typically be in the range from 0 to 3, the original
statement will never use SEC_MINI_B for sat_no 1 respectively 3.

Bye.
-- 
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rnissl at gmx.de



More information about the linux-dvb mailing list