[linux-dvb] cxusb.c need bug fix for Architecture Dependency (Little/Big endian)

Michael Krufky mkrufky at linuxtv.org
Thu Feb 15 07:06:56 CET 2007


이진봉 wrote:
> fixup needed in changing of fw-data for Big endian system.
> If don't fix this problem, Big endian system can't probe this dvb device.
> 
> This patch make dvb device to be able probe & active both of Little endian system and Big endian System.

I've tested your patch on my machine, and it works as expected.
However, you generated the patch against an older revision and did not
provide a sign-off with your patch.

I have regenerated your patch against the master v4l-dvb devel tree. (see below)

Please respond to this email with your sign-off, in the form:

Signed-off-by: Your Name <email at addre.ss>

...so that I can add your patch into the official sources.

For more info, see: http://linuxtv.org/hg/v4l-dvb?f=-1;file=README.patches

Regards,

Michael Krufky

---
 linux/drivers/media/dvb/dvb-usb/cxusb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- v4l-dvb.orig/linux/drivers/media/dvb/dvb-usb/cxusb.c
+++ v4l-dvb/linux/drivers/media/dvb/dvb-usb/cxusb.c
@@ -469,9 +469,9 @@
 	    fw->data[BLUEBIRD_01_ID_OFFSET + 1] == USB_VID_DVICO >> 8) {
 
 		fw->data[BLUEBIRD_01_ID_OFFSET + 2] =
-			udev->descriptor.idProduct + 1;
+			le16_to_cpu(udev->descriptor.idProduct) + 1;
 		fw->data[BLUEBIRD_01_ID_OFFSET + 3] =
-			udev->descriptor.idProduct >> 8;
+			le16_to_cpu(udev->descriptor.idProduct) >> 8;
 
 		return usb_cypress_load_firmware(udev, fw, CYPRESS_FX2);
 	}



More information about the linux-dvb mailing list