[linux-dvb] AGC settings for dtt761x, removal of lgh06xf driver
xyzzy at speakeasy.org
Mon Feb 26 22:58:18 CET 2007
On Mon, 26 Feb 2007, Michael Krufky wrote:
> Trent Piepho wrote:
> > There is one other difference. dvb-pll will probe for the presence of an
> > I2C pll chip by doing a one byte read, the lgh06xf driver did not do
> > this. In some devices the PLL is not reachable over I2C at the time the
> > tuner is attached. Some more initialization, such as firmware loading,
> > must take place first. If any of these devices are former LG-H06xF
> > users, something must be done to disable this probe or enable I2C before
> > attaching the tuner.
> LG-H06xF tuners do not have any sort of i2c gate or firmware loading situation,
> and will not be affected by this issue. So, we do not have to worry about this
> sort of problem.
I think the problem is not with firmware for the tuner, but firmware for
the bridge. For instance, all the other dvb-pll tuners used in cxusb.c
have NULL specified for the i2c adapter.
> - select DVB_TUNER_LGH06XF if !DVB_FE_CUSTOMISE
> + select DVB_PLL if !DVB_FE_CUSTOMISE
I thought about that, but there are a dozen other drivers that use DVB_PLL,
and all of them select it unconditionally. The DVB_PLL entry is a "hidden"
one with no name that won't show up it the config menu. Of course, there
is no reason a separate patch can't add the ability to turn DVB_PLL on or
off from the DVB_FE_CUSTOMISE menu.
> You forgot to remove "select DVB_TUNER_LGH06XF if !DVB_FE_CUSTOMISE" from the
> "config VIDEO_CX88_DVB" section of drivers/media/video/cx88/Kconfig ...
Of course you are right about this. I grepped for LGH06XF in the dvb tree
and assumed that I got them all. I'll fix this and add another patch to
make DVB_PLL customizable.
More information about the linux-dvb