[linux-dvb] [PATCH] [RFC] remove static dependencies on dvb-pll

Uwe Bugla uwe.bugla at gmx.de
Sat Jun 2 19:27:08 CEST 2007


Am Samstag, 2. Juni 2007 18:56 schrieben Sie:
> Uwe Bugla wrote:
> > Am Samstag, 2. Juni 2007 05:33 schrieben Sie:
> >> Uwe Bugla wrote:
> >>> OK, Mike: I am just adjusting your latest approach due to Email issues
> >>> of wordwrapping. Could you please be kind enough to supply another
> >>> patch including Trent's changes?
> >>
> >> Revised patch attached.
> >
> > Thanks, Michael!
> > I got enourmous wordwrapping troubles with:
> > - getting this stuff copied with KWrite
> > - producing a patch to be applied easily against 2.6.22-rc3
> >
> > Would you please resend it as outline attachment or by using another
> > sending method so that I can apply it for testing purpose against the
> > latest kernel tree without any wordwrapping hassle?
>
> Uwe,
>
> I included the patch to my email as a file attachment, so it's strange
> that you're having line-wrapping problems...

I am working with Kmail.
That means I need to copy the whole patchset into a new file after having 
opened Kwrite. This causes a lot of trouble:
- All the context lines get corrupted.
- All blanks get corrupted
- All tabs get corrupted
- All additions get corrupted
- All substractions get corrupted

Thus you are forced to rewrite the whole thing, which is not agreeable and a 
big pain.

> Regardless, I've made some 
> additional changes to this patch, and rolled them all into this new
> patch here:
>
> http://linuxtv.org/~mkrufky/remove-static-dependencies-on-dvb-pll.patch

YUP! Thank you for that! This link at least avoids the trouble mentioned 
above! Well done, Mike! :)
And at least sometimes a combination of inline and outline attachment is doing 
real fine, although it breaks the "golden rules" of Andrew Morton.

However, the output applying this against 2.6.22-rc3 causes other trouble:

See yourself please:

brian:/usr/src# patch -p1 -i dvbpll.patch
patching file linux/drivers/media/dvb/b2c2/Kconfig
patching file linux/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
Hunk #1 succeeded at 500 (offset -11 lines).
patching file linux/drivers/media/dvb/bt8xx/Kconfig
Hunk #1 succeeded at 7 with fuzz 2.
patching file linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c
Hunk #1 succeeded at 611 (offset -1 lines).
patching file linux/drivers/media/dvb/dvb-usb/Kconfig
patching file linux/drivers/media/dvb/dvb-usb/cxusb.c
Hunk #1 FAILED at 355.
1 out of 1 hunk FAILED -- saving rejects to file 
linux/drivers/media/dvb/dvb-usb/cxusb.c.rej
patching file linux/drivers/media/dvb/dvb-usb/dibusb-common.c
patching file linux/drivers/media/dvb/dvb-usb/dibusb-mb.c
Hunk #1 FAILED at 33.
1 out of 1 hunk FAILED -- saving rejects to file 
linux/drivers/media/dvb/dvb-usb/dibusb-mb.c.rej
patching file linux/drivers/media/dvb/dvb-usb/digitv.c
patching file linux/drivers/media/dvb/dvb-usb/dvb-usb-i2c.c
Hunk #2 FAILED at 84.
1 out of 2 hunks FAILED -- saving rejects to file 
linux/drivers/media/dvb/dvb-usb/dvb-usb-i2c.c.rej
patching file linux/drivers/media/dvb/dvb-usb/dvb-usb.h
Hunk #1 succeeded at 300 (offset -3 lines).
patching file linux/drivers/media/dvb/dvb-usb/opera1.c
Hunk #1 succeeded at 263 (offset -11 lines).
patching file linux/drivers/media/dvb/dvb-usb/umt-010.c
Hunk #1 FAILED at 65.
1 out of 1 hunk FAILED -- saving rejects to file 
linux/drivers/media/dvb/dvb-usb/umt-010.c.rej
patching file linux/drivers/media/dvb/frontends/dvb-pll.c
Hunk #2 succeeded at 55 with fuzz 2 (offset -6 lines).
Hunk #3 succeeded at 69 (offset -6 lines).
Hunk #4 succeeded at 82 with fuzz 2 (offset -6 lines).
Hunk #5 succeeded at 89 (offset -7 lines).
Hunk #6 succeeded at 105 (offset -7 lines).
Hunk #7 succeeded at 121 (offset -7 lines).
Hunk #8 succeeded at 134 (offset -7 lines).
Hunk #9 succeeded at 149 (offset -7 lines).
Hunk #10 succeeded at 168 (offset -7 lines).
Hunk #11 succeeded at 184 (offset -7 lines).
Hunk #12 succeeded at 199 (offset -7 lines).
Hunk #13 succeeded at 209 (offset -7 lines).
Hunk #14 succeeded at 231 (offset -8 lines).
Hunk #15 succeeded at 241 (offset -8 lines).
Hunk #16 succeeded at 254 (offset -8 lines).
Hunk #17 succeeded at 271 (offset -8 lines).
Hunk #18 succeeded at 281 (offset -9 lines).
Hunk #19 succeeded at 298 (offset -11 lines).
Hunk #20 succeeded at 308 (offset -11 lines).
Hunk #21 succeeded at 322 (offset -11 lines).
Hunk #22 succeeded at 339 (offset -11 lines).
Hunk #23 FAILED at 356.
Hunk #24 succeeded at 355 (offset -25 lines).
Hunk #25 succeeded at 374 (offset -25 lines).
Hunk #26 succeeded at 391 (offset -25 lines).
Hunk #27 succeeded at 414 (offset -25 lines).
Hunk #28 succeeded at 433 (offset -25 lines).
Hunk #29 FAILED at 448.
Hunk #30 succeeded at 473 (offset -25 lines).
Hunk #31 succeeded at 511 (offset -25 lines).
Hunk #32 FAILED at 525.
Hunk #33 succeeded at 579 (offset -27 lines).
Hunk #34 FAILED at 617.
Hunk #35 FAILED at 645.
Hunk #36 succeeded at 687 (offset -15 lines).
Hunk #37 succeeded at 722 (offset -15 lines).
Hunk #38 succeeded at 752 (offset -15 lines).
5 out of 38 hunks FAILED -- saving rejects to file 
linux/drivers/media/dvb/frontends/dvb-pll.c.rej
patching file linux/drivers/media/dvb/frontends/dvb-pll.h
Hunk #1 FAILED at 8.
1 out of 2 hunks FAILED -- saving rejects to file 
linux/drivers/media/dvb/frontends/dvb-pll.h.rej
patching file linux/drivers/media/dvb/ttpci/Kconfig
patching file linux/drivers/media/dvb/ttpci/budget-av.c
Hunk #1 FAILED at 966.
1 out of 1 hunk FAILED -- saving rejects to file 
linux/drivers/media/dvb/ttpci/budget-av.c.rej
patching file linux/drivers/media/video/cx88/Kconfig
patching file linux/drivers/media/video/cx88/cx88-dvb.c
Hunk #1 succeeded at 456 (offset 69 lines).
Hunk #2 succeeded at 469 (offset 69 lines).
Hunk #3 succeeded at 482 (offset 69 lines).
Hunk #4 succeeded at 491 (offset 69 lines).
Hunk #5 succeeded at 500 (offset 69 lines).
Hunk #6 succeeded at 511 (offset 69 lines).
Hunk #7 succeeded at 520 (offset 69 lines).
Hunk #8 succeeded at 529 (offset 69 lines).
Hunk #9 succeeded at 540 (offset 69 lines).
Hunk #10 FAILED at 549.
Hunk #11 succeeded at 563 (offset 70 lines).
Hunk #12 succeeded at 572 (offset 70 lines).
Hunk #13 succeeded at 594 (offset 70 lines).
Hunk #14 succeeded at 614 (offset 70 lines).
Hunk #15 succeeded at 634 (offset 70 lines).
Hunk #16 succeeded at 654 (offset 70 lines).
Hunk #17 succeeded at 664 (offset 70 lines).
1 out of 17 hunks FAILED -- saving rejects to file 
linux/drivers/media/video/cx88/cx88-dvb.c.rej
patching file linux/drivers/media/video/saa7134/Kconfig
patching file linux/drivers/media/video/saa7134/saa7134-dvb.c
Hunk #1 FAILED at 856.
Hunk #2 FAILED at 865.
Hunk #3 succeeded at 1113 (offset 150 lines).
Hunk #4 succeeded at 1121 (offset 150 lines).
Hunk #5 FAILED at 1146.
3 out of 5 hunks FAILED -- saving rejects to file 
linux/drivers/media/video/saa7134/saa7134-dvb.c.rej

OKIDOK! If you can promise me and others that this is your "final" version I 
am inclined to do the following now:

1. Adjust your work for being applied against 2.6.22-rc3
2. Test your work
3. Send it in again in a corrected version (without offsets, rejects and fuzz 
factors plus the pre-condition of having applied Trent's work for dst 
customization before applying your stuff).

You've offered lots of help now for which I am very thankful.
So please have some patience and let me do the rest, OK?

There is no discussion that your work (plus Trent's inputs of course) is far 
more better than mine or Markus's.

>
> The patch was generated against v4l-dvb.hg ... I can't promise that it
> will apply cleanly against 2.6.22-rc3, although I see no reason why
> not...  You may run into a hunk failure when it comes to dvb_pll_desc
> *dvb_pll_opera1.
>
> Cheers,
>
> Mike

Best Regards and Thanks

Uwe

P. S.: I still do not understand the essence of this pll library as far as
- performance
- stability
- other functionalities

are concerned. Would be really keen on understanding the theoretical 
background / use of this Gerd-Knorr-relic.



More information about the linux-dvb mailing list