[linux-dvb] Re: [PATCH] Make saa7134-dvb less noisy

Trent Piepho xyzzy at speakeasy.org
Mon Mar 5 23:13:50 CET 2007


Tim Small wrote:
> I use mythtv, and this periodically opens DVB cards to check for new EIT
> data.  Because of this, I end up with hundreds of:
>
> mt352_pinnacle_init called
>
> lines in my kernel log.
>
> The attached patch makes saa7134-dvb quieter.

This patch looks to be against an older version of the saa7134-dvb driver.
The current version already has a dprintk macro and a debug parameter.

I've made a patch against the current version of the driver which should
clean up all the printk()s.  There were several that are changed from
printk to dprintk, and some others that have a level like KERN_WARNING or
KERN_ERR added.  I also tried to make the format consistent.  The dprintk
macro wasn't safe.  e.g.
if(!working)
    dprintk("foo");
else
    whatever();

Wouldn't do what you might expect!  That's been fixed too.

Patch is here:
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=b7320b447a26;style=gitweb



More information about the linux-dvb mailing list