[linux-dvb] Common interface on Technotrend S-1500 broken in v4l-dvb?

[P. van Gaans]

On 10/14/2007 07:54 PM, Oliver Endriss wrote:
> Oliver Endriss wrote:
>> P. van Gaans wrote:
>>> On 10/14/2007 12:11 AM, Oliver Endriss wrote:
>>>> P. van Gaans wrote:
>>>>> Today I was testing some stuff and downloaded and installed the newest 
>>>>> v4l-dvb from hg. After a while I figured out that FTA channels on my TT 
>>>>> S-1500 still worked, but the CAM would not respond. I checked all 
>>>>> connections, re-inserted the CAM, reboot the computer but nothing would 
>>>>> help. My CI daughterboard version is 1.1 and I bought this S-1500 end of 
>>>>> august 2007. I use Ubuntu 7.04 with kernel 2.6.20-16-generic.
>>>>>
>>>>> After installing a somewhat older version of v4l-dvb I luckily had left 
>>>>> on my harddisk, the common interface directly came back to life.
>>>> Could you please try to find out which changeset broke the code?
>>>>
>>>> If you have a current HG checkout, you can update the driver to a given
>>>> version using 'hg update <no of changeset>'.
>>>>
>>>>> Maybe I just did something wrong somewhere, but would it be possible 
>>>>> some big change was made to the way the S-1500 handles the CI that could 
>>>>> have broken it?
>>>> It's probably a change in budget-ci.c or dvb_ca_en50221.c
>>>>
>>>> Just an educated guess:
>>>> Did   http://linuxtv.org/hg/v4l-dvb/rev/b0a3a9b43d60
>>>> break the code? -> 'hg update 6279'
>>>>
>>>> CU
>>>> Oliver
>>>>
>>> 6279 does not compile.
>>>
>>> make -C /home/wn/v4l-dvb/v4l
>>> make[1]: Entering directory `/home/wn/v4l-dvb/v4l'
>>> perl scripts/make_config_compat.pl /lib/modules/2.6.20-16-generic/source
>>> ./.myconfig ./config-compat.h
>>> File not found:
>>> /lib/modules/2.6.20-16-generic/source/include/linux/netdevice.h at
>>> scripts/make_config_compat.pl line 15.
>>> make[1]: *** [config-compat.h] Error 2
>>> make[1]: Leaving directory `/home/wn/v4l-dvb/v4l'
>>> make: *** [all] Error 2
>>>
>>> After trying a bit I figured out 6266 does compile. Everything between
>>> 6279 and 6266 does not. I can tell you that with 6266, the common 
>>> interface works, I hope that's enough info.
>> Now I have a confirmation from Marco Schluessler that changeset
>>   http://linuxtv.org/hg/v4l-dvb/raw-rev/b0a3a9b43d60
>> broke CI support.
>>
>> For now simply revert this changeset.
>> Save http://linuxtv.org/hg/v4l-dvb/raw-rev/b0a3a9b43d60 to a file.
>> Then use 'patch -p1 -R < file' to revert the changeset.
> 
> Marco sent me the attached patch which should fix the problem.
> Please test.
> 
> CU
> Oliver
> 
> 
> 
> ------------------------------------------------------------------------
> 
> - "while (!ca->wakeup)" breaks the CAM initialisation
> 
> Signed-off-by: Marco Schluessler <marco at lordzodiac.de>
> 
> diff -bur v4l-dvb-ea93c93f1547_orig/linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c v4l-dvb-ea93c93f1547/linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c
> --- v4l-dvb-ea93c93f1547_orig/linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c	2007-10-14 13:19:25.000000000 +0200
> +++ v4l-dvb-ea93c93f1547/linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c	2007-10-14 18:37:15.000000000 +0200
> @@ -973,7 +973,7 @@
>  	/* main loop */
>  	while (!kthread_should_stop()) {
>  		/* sleep for a bit */
> -		while (!ca->wakeup) {
> +		if (!ca->wakeup) {
>  			set_current_state(TASK_INTERRUPTIBLE);
>  			schedule_timeout(ca->delay);
>  			if (kthread_should_stop())
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> linux-dvb mailing list
> linux-dvb at linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

I wanted to test it but just downloaded the latest v4l-dvb and see the 
patch is already applied. Common interface works with latest v4l-dvb 
(oct 16 2007).

P.