[linux-dvb] [v4l-dvb-maintainer] FWD: [Patch] saa7146/budget*/dvb-ttpci: Remove V4L1 dependencies

Mauro Carvalho Chehab mchehab at infradead.org
Mon Oct 29 16:11:55 CET 2007


> Basically the enum is not required.
> Everything works fine without replacing VIDEO_MODE_xxx by 
> AV7110_VIDEO_MODE_xxx. (VIDEO_MODE_xxx is defined in videodev.h.)
> 
> On the other hand, I like the enum because it defines the interface
> between firmware and driver in a clean way. video_tuner->mode defines
> should not be used here because anything except VIDEO_MODE_PAL or
> VIDEO_MODE_NTSC are not valid for the firmware. In the future the enum
> might be extended to display NTSC content on a PAL TV...

For me, having the enum is overkill, but this doesn't hurt.
So, let's then keep the enum if you wish.

> > Also, please review the patch with scripts/checkpatch.pl.
> 
> Will do so.

Ok, thanks.

-- 
Cheers,
Mauro




More information about the linux-dvb mailing list