[linux-dvb] xc2028-tuner: current cvs/hg code broken?

Hans-Frieder Vogt hfvogt at gmx.net
Sun Apr 27 12:30:25 CEST 2008


Hi list,

trying to get the DVICO FusionHDTV Dual Express running with the current v4l-dvb development tree, I ran continuously into kernel oops.
When I traced these back I found, that tuner-xc2028.c must have been changed recently (OK, sometime between the 9th march and the 22th april) and makes several drivers fail as a consequence.

In the tuner-xc2028.c from the 9th march snapshot, in xc2028_attach the definition of video_dev was:
video_dev = cfg->video_dev;
In current v4l-dvb snapshots, it is defined as
video_dev = cfg->i2c_adap->algo_data;

=> any video_dev definition in a struct xc2028_config is without any effect! Therefore any driver that relies on video_dev to be as set in the xc2028_config will run into trouble as soon as the tuner_callback is called.

it seems, that the problem raised in http://www.linuxtv.org/pipermail/linux-dvb/2008-March/025076.html could be related.

I completely missed that change in the mailing list.

Can anybody please point me to a explanation or discussion of that change? If we intend to leave the definition of video_dev in tuner-xc2028.c as it is currently, wouldn't it be then a good idea to remove the video_dev field in structure xc2028_config, to force all drivers which may rely on that field to be reviewed?

Thanks,
Hans-Frieder

-- 
--
Hans-Frieder Vogt                 e-mail: hfvogt <at> gmx .dot. net



More information about the linux-dvb mailing list