[linux-dvb] Problem with latest v4l-dvb hg

[timf]

Mauro Carvalho Chehab wrote:
> Hi Tim,
>
> I'm not sure if it is the same bug, but, on a device I have with tda10046, I
> need to slow firmware load, otherwise, it will fail. This happens on an AMD 64
> dual core notebook @1.8GHz. The same board, on an Intel single core @1.1GHz
> works without troubles.
>
> Please test the enclosed patch.
>
> On Mon, 09 Jun 2008 20:24:19 +0800
> timf <timf at iinet.net.au> wrote:
>
>   
>>> [   38.194402] tuner' 2-004b: chip found @ 0x96 (saa7133[0])
>>> [   38.286214] tda829x 2-004b: setting tuner address to 61
>>> [   38.370076] tda829x 2-004b: type set to tda8290+75a
>>> [   42.195417] saa7133[0]: registered device video0 [v4l2]
>>> [   42.195437] saa7133[0]: registered device vbi0
>>> [   42.195461] saa7133[0]: registered device radio0
>>> [   42.355808] DVB: registering new adapter (saa7133[0])
>>> [   42.355815] DVB: registering frontend 0 (Philips TDA10046H DVB-T)...
>>> [   42.427655] tda1004x: setting up plls for 48MHz sampling clock
>>> [   44.678388] tda1004x: timeout waiting for DSP ready
>>> [   44.718322] tda1004x: found firmware revision 0 -- invalid
>>> [   44.718326] tda1004x: trying to boot from eeprom
>>>       
>
>
> diff -r 000ffc33cb89 linux/drivers/media/dvb/frontends/tda1004x.c
> --- a/linux/drivers/media/dvb/frontends/tda1004x.c	Sat Jun 14 08:27:34 2008 -0300
> +++ b/linux/drivers/media/dvb/frontends/tda1004x.c	Sat Jun 14 08:53:01 2008 -0300
> @@ -135,6 +135,9 @@
>  
>  	msg.addr = state->config->demod_address;
>  	ret = i2c_transfer(state->i2c, &msg, 1);
> +
> +	if (state->config->xtal_freq == TDA10046_XTAL_16M)
> +		msleep(1);
>  
>  	if (ret != 1)
>  		dprintk("%s: error reg=0x%x, data=0x%x, ret=%i\n",
>
>
>
> Cheers,
> Mauro
>
>   
Hi Mauro,
Patch applied, hard to tell if improved.

Prior to patch:
Strange thing, maybe useful info, seems if boot from shutdown overnight, 
never loads firmware, always "revision ff"
Always have to restart, sometimes a few times, for firmware to load.

dmesg after patch, reboot:

[   41.504805] saa7133[0]: registered device vbi0
[   41.504836] saa7133[0]: registered device radio0
[   41.504913] tuner' 2-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
[   41.673243] DVB: registering new adapter (saa7133[0])
[   41.673249] DVB: registering frontend 0 (Philips TDA10046H DVB-T)...
[   41.784037] tda1004x: setting up plls for 48MHz sampling clock
[   44.123523] tda1004x: timeout waiting for DSP ready
[   44.179434] tda1004x: found firmware revision 0 -- invalid
[   44.179436] tda1004x: trying to boot from eeprom
<snip>
[   46.511807] tda1004x: timeout waiting for DSP ready
[   46.567659] tda1004x: found firmware revision 0 -- invalid
[   46.567665] tda1004x: waiting for firmware upload...
[   47.166298] tuner' 2-004b: Cmd AUDC_SET_RADIO accepted for radio
[   47.166307] tuner' 2-004b: radio freq set to 87.50
[   59.147648] tda1004x: found firmware revision 29 -- ok
[   59.675203] tda827x_probe_version: could not read from tuner at addr: 
0xc2
[   60.099525] tuner' 2-004b: Cmd TUNER_SET_STANDBY accepted for radio

sysinfo:
AMD Athlon(tm) 64 X2 Dual Core Processor 3600+

Regards,
Timf