[linux-dvb] DVBFE_SET_PARAMS / delsys from fe_info ioctl ?

[Florian Lohoff]

On Mon, Mar 03, 2008 at 03:09:23PM +0400, Manu Abraham wrote:
> >As i already wrote - SET_PARAMS is _NOT_ enough. Please try yourself. 
> >Unload/Load the module and simple issue a DVBFE_SET_PARAMS (NOT
> >GET_INFO) and it doesnt tune/lock at least for STB0899 and it also
> >complains in the dmesg with:
> >
> >	stb0899_search: Unsupported delivery system 0
> >	stb0899_read_status: Unsupported delivery system 0
> >	stb0899_search: Unsupported delivery system 0
> >	stb0899_read_status: Unsupported delivery system 0
> >	stb0899_search: Unsupported delivery system 0
> >	stb0899_read_status: Unsupported delivery system 0
> >
> >although i set
> >
> >	dvbfe_params.delivery=DVBFE_DELSYS_DVBS2;
> 
> Yep, it isn't supposed to work that way with simply issuing SET_PARAMS.

Okay - So either 

- remove the "delivery" in the dvbfe_params because it is unnecessary,
  confusing and broken, and rename the GET_INFO call to SET_DELIVERY
  or something which implies that its not a _GET_ call

or 

- make SET_PARAMS the call to honor delivery in dvbfe_params and remove
  the setting of the delivery of GET_INFO

I'd prefere the 2nd option because currently the usage and naming
is an incoherent mess which should better not get more adopters ..

Flo
-- 
Florian Lohoff                  flo at rfc822.org             +49-171-2280134
	Those who would give up a little freedom to get a little 
          security shall soon have neither - Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20080303/f15af449/attachment.pgp