<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:times new roman, new york, times, serif;font-size:12pt"><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;">Thanks for the hints.<br>
<br>
I made a driver update yesterday for kernel 2.6.24 using the last v4l tree I got:<br>v4l-dvb-2daeefda69fe, so probably that will be much more closer to the actual tree.<br>- Is there any way to submit it for review?<br><br>About your hints:<br>- you mean that static variables will be an issue.<br>Could then be better to include those variables in dvb_usb_device_properties?<br><br>- Yes, the register increment has no use. I can remove it away.<br><br>- I also got feedback that the debug information is not handled correctly in the driver.<br>Could you advice on that one?<br><br>I am really no expert, I have just been following the examples.<br>But since it is working, it would be great if people could use the driver.<br><br>Juan<br><br><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;">----- Mensaje original ----<br>De: Aidan Thornton <makosoft@googlemail.com><br>Para: Juan Antonio Garcia
<juanantonio_garcia_01@yahoo.es><br>CC: Markus Rechberger <mrechberger@gmail.com>; Jakob Steidl <j.steidl@liwest.at>; linux-dvb@linuxtv.org<br>Enviado: viernes, 2 de mayo, 2008 12:24:07<br>Asunto: Re: [linux-dvb] DVB driver for Pinnacle PCTV200e and PCTV60e<br><br>On Thu, May 1, 2008 at 8:58 PM, Markus Rechberger <<a ymailto="mailto:mrechberger@gmail.com" href="mailto:mrechberger@gmail.com">mrechberger@gmail.com</a>> wrote:<br>> Hi,<br>><br>><br>> On 5/1/08, Juan Antonio Garcia <<a ymailto="mailto:juanantonio_garcia_01@yahoo.es" href="mailto:juanantonio_garcia_01@yahoo.es">juanantonio_garcia_01@yahoo.es</a>> wrote:<br>> ><br>> > Hi,<br>> ><br>> > I updated the driver for being supported in kernel 2.6.24 (Ubuntu 8.04).<br>> ><br>> > I am distributing the update thought the Ubuntu forums, but it would be<br>> > better to
distribute it to more users. So Linux has more HW supported.<br>> ><br>> > What it should be done so it is included in the v4l tree?<br>> ><br>><br>> I forwarded the mail to the linux-dvb ML.<br>><br>> > Now the driver supports 2 devices:<br>> ><br>> > - Pinnacle PCTV 200e<br>> > - Pinnacle PCTV 60e<br>> ><br>> > The driver wiki is:<br>> ><br>> > <a href="http://www.linuxtv.org/wiki/index.php/Pinnacle_PCTV_200e" target="_blank">http://www.linuxtv.org/wiki/index.php/Pinnacle_PCTV_200e</a><br>> ><br>><br>> Markus<br><br>Hi,<br><br>This driver seems like it should be trivial to get working on<br>linux-dvb, which is where you want it - the tree you've based it on<br>isn't much longer for this world. (I don't think any of the code<br>you're using has changed significantly between Markus'
branch and the<br>main one). It needs some cleanup, though. At a glance:<br><br>- Don't use C++-style comments (the single-line // ones)<br>- The whole "addr == pctv200e_mt2060_config.i2c_address" part looks<br>iffy; I think you should remove this and use i2c_gate_ctrl instead.<br>Unfortunately, I'm not sure this'll work currently, since mt2060<br>doesn't appear to support it.<br>- ctrl_msg_last_device/ctrl_msg_last_operation must go - they won't<br>work right if you use multiple devices of this type. The code in the<br>"if (ctrl_msg_last_device == 0)" section can probably go elsewhere,<br>but I'm not sure where<br>- Why are you incrementing the register value in pctv200e_ctrl_msg?<br><br>The linuxtv developers will probably be able to give you more advice.<br><br>Aidan<br></div><br></div></div><br>
<hr size=1><br><font face="Verdana" size="-2"><a href="http://us.rd.yahoo.com/mailuk/taglines/isp/control/*http://us.rd.yahoo.com/evt=52433/*http://green.yahoo.com/es/dia-de-la-tierra/">Yahoo! Solidario.</a><br>Intercambia los objetos que ya no necesitas y ayuda a mantener un entorno más ecológico.<br></font></body></html>