<div dir="ltr"><br><br><div class="gmail_quote">On Wed, Nov 12, 2008 at 10:54 PM, Darron Broad <span dir="ltr"><<a href="mailto:darron@kewl.org">darron@kewl.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
In message <<a href="mailto:c74595dc0811121232s48a95a14v93edf27360ed5c21@mail.gmail.com">c74595dc0811121232s48a95a14v93edf27360ed5c21@mail.gmail.com</a>>, "Alex Betis" wrote:<br>
><br>
>Hi All,<br>
<br>
Hi.<br>
<div><div></div><div class="Wj3C7c"><br>
>A question regarding the error code returned from the driver when using<br>
>DTV_TUNE property.<br>
>Following the code I came to dvb_frontend_ioctl_legacy function and reached<br>
>the FE_SET_FRONTEND case.<br>
>Looking on the logic I couldn't see any handling of error tuning, an event<br>
>is added to the frontend and zero is returned:<br>
><br>
> fepriv->state = FESTATE_RETUNE;<br>
> dvb_frontend_wakeup(fe);<br>
> dvb_frontend_add_event(fe, 0);<br>
> fepriv->status = 0;<br>
> err = 0;<br>
> break;<br>
><br>
>How should an application know that DTV_TUNE command succeed?<br>
>Monitoring the LOCK bit is not good, here's an example why I ask the<br>
>question:<br>
><br>
>Assuming the cx24116 driver is locked on a channel. Application sends tune<br>
>command to another channel while specifying<br>
>AUTO settings for modulation and FEC. The driver for that chip cant handle<br>
>AUTO settings and return error, while its still connected<br>
>to previous channel. So in that case LOCK bit will be ON, while the tune<br>
>command was ignored.<br>
><br>
>I thought of an workaround to query the driver for locked frequency and<br>
>check whenever its in bounds of frequency that was ordered<br>
>to be tuned + - some delta, but that's a very dirty solution.<br>
><br>
>Any thoughts? Or I'm missing something?<br>
<br>
</div></div>Correct me if I am wrong, but I remember looking at this before...<br>
<br>
The problem is that no capabilities are available for S2API demods as yet<br>
so TUNE always succeeds whether the parameters are wrong or right.<br>
<br>
What is needed is:<br>
1. caps for s2api aware demods.<br>
2. extend dvb_frontend_check_parameters() for s2api aware demods.<br>
</blockquote><div>You mean passing the parameter to the demods to be checked before performing the tuning?<br>Is there an example of that usage?<br>What about some unexpected failures that can't be checked before the tuning? Can't think of a real example since I'm not too familiar with<br>
the code. <br>I thought about a property of "last error code" that can be queried from the driver, but in that case the application has to be aware when<br>the tuning is finished.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
This hasn't been done as yet.<br>
<br>
cya<br>
<font color="#888888"><br>
--<br>
<br>
// /<br>
{:)==={ Darron Broad <<a href="mailto:darron@kewl.org">darron@kewl.org</a>><br>
\\ \<br>
<br>
</font></blockquote></div><br></div>