<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:times new roman, new york, times, serif;font-size:12pt"><DIV>Looking at this patch. I have a couple of stupid questions.</DIV>
<DIV> </DIV>
<DIV>
<DIV style="COLOR: #ff0000">- up(&usbvision->lock);<BR></DIV>
<DIV style="COLOR: #00ff00">+ mutex_unlock(&usbvision->lock);<BR></DIV>
<DIV> <BR>
<DIV style="COLOR: #00ff00">+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)<BR></DIV>
<DIV style="COLOR: #00ff00">+#include <linux/mutex.h><BR></DIV>
<DIV style="COLOR: #00ff00">+#endif<BR></DIV>
<DIV> #include <media/v4l2-common.h><BR></DIV>
<DIV> #include <media/tuner.h><BR></DIV>
<DIV> #include <linux/videodev2.h><BR></DIV>
<DIV style="COLOR: #ff00ff">@@ -397,7 +400,11 @@ struct usb_usbvision {<BR></DIV>
<DIV> unsigned char iface; /* Video interface number */<BR></DIV>
<DIV> unsigned char ifaceAlt; /* Alt settings */<BR></DIV>
<DIV> unsigned char Vin_Reg2_Preset;<BR></DIV>
<DIV style="COLOR: #ff0000">- struct semaphore lock;<BR></DIV>
<DIV style="COLOR: #00ff00">+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)<BR></DIV>
<DIV style="COLOR: #00ff00">+ struct mutex lock;<BR></DIV>
<DIV style="COLOR: #00ff00">+#else<BR></DIV>
<DIV style="COLOR: #00ff00">+ struct semaphore lock;<BR></DIV>
<DIV style="COLOR: #00ff00">+#endif<BR></DIV>
<DIV style="COLOR: #00ff00"><FONT color=#000000>Do we really need to check the kernel version? We just removed all the old susbvision->lock semaphores to the mutex API</FONT></DIV><FONT color=#000000></FONT></DIV><FONT color=#000000></FONT></DIV>
<P><FONT color=#000000></FONT> </P>
<P><FONT color=#000000>Dwaine</P>
<DIV style="COLOR: #00ff00"><BR></DIV></FONT></div></body></html>