[linuxtv-cvs] dvb-kernel

Johannes Stezenbach js at linuxtv.org
Tue Aug 16 13:21:36 CEST 2005


Patrick Boettcher wrote:
> On Tue, 16 Aug 2005, Johannes Stezenbach wrote:
> 
> >On Tue, Aug 16, 2005 at 12:11:24PM +0200, Patrick Boettcher via CVS wrote:
> >>Log message:
> >>changed the init call to get the dvb_usb_device back immediatly if 
> >>necessary.
> >
> >What does this mean? Can you give me a better patch description, please?
> 
> A instance of struct dvb_usb_device is created for each dvb-usb-device 
> when calling
> 
> int dvb_usb_device_init(struct usb_interface *intf, struct 
> dvb_usb_properties *props, struct module *owner);
> 
> from the driver's probe-function.
> 
> I changed this call to
> 
> int dvb_usb_device_init(struct usb_interface *intf, struct
> dvb_usb_properties *props, struct module *owner, struct dvb_usb_device 
> **du);
> 
> to get the struct dvb_usb_device instance back directly in order to do 
> something with rather than calling usb_get_intfdata first.
> 
> Sorry for my shortness in the first place.

Now it's too long ;-/

How about "Return he newly created struct dvb_usb_device from
dvb_usb_device_init() to avoid having to call usb_get_intfdata()
seperately to get it.".

Or something like that...

I hate it when I have to come up with my own patch descriptions
when I create patches for lkml, so please write your commit
log entries with that in mind.

Thanks,
Johannes



More information about the linuxtv-cvs mailing list