[vdr] VDR-1.3.46 Segmentation fault

[Dr. Werner Fink]

On Mon, Apr 10, 2006 at 02:50:35AM +0100, Darren Salt wrote:
> I demand that I definitely did write...
> 
> > I demand that Thomas Günther may or may not have written...
> >> If I try to set the time transponder the vdr crashes. :-(
> >> Program received signal SIGSEGV, Segmentation fault.
> 
> >> (gdb) bt
> >> #0  0x401f4cff in strlen () from /lib/libc.so.6
> >> #1  0x401f4a55 in strdup () from /lib/libc.so.6
> >> #2  0x080e0b2f in cMenuEditItem::SetValue (this=0xa268768, Value=0x0) at menuitems.c:39
> 
> > I suggest replacing that line with
> >   value = Value ? strdup(Value) : NULL;
> [snip]
> 
> Full patch attached. On enabling the "set time from broadcast" function,
> default to the first available channel.

Hmmm ... strdup() can return NULL if the system is
low at or out of memory.


> -  value = strdup(Value);
> +  value = Value ? strdup(Value) : NULL;


        Werner

-- 
AC3 loop through sound card http://bitstreamout.sourceforge.net/
Howto http://www.vdr-portal.de/board/thread.php?threadid=1958
------------------------------------------------------------------
 "Having a smoking section in a restaurant is like having
         a  peeing section in a swimming pool." -- Edward Burr