[vdr] VDR-1.3.46 Segmentation fault
linux at youmustbejoking.demon.co.uk
Mon Apr 10 19:56:00 CEST 2006
I demand that Dr. Werner Fink may or may not have written...
> On Mon, Apr 10, 2006 at 02:50:35AM +0100, Darren Salt wrote:
>> I demand that I definitely did write...
>>> I demand that Thomas Günther may or may not have written...
>>>> If I try to set the time transponder the vdr crashes. :-( Program
>>>> received signal SIGSEGV, Segmentation fault.
>>>> (gdb) bt
>>>> #0 0x401f4cff in strlen () from /lib/libc.so.6
>>>> #1 0x401f4a55 in strdup () from /lib/libc.so.6
>>>> #2 0x080e0b2f in cMenuEditItem::SetValue (this=0xa268768, Value=0x0) at menuitems.c:39
>>> I suggest replacing that line with
>>> value = Value ? strdup(Value) : NULL;
>> Full patch attached. On enabling the "set time from broadcast" function,
>> default to the first available channel.
> Hmmm... strdup() can return NULL if the system is low at or out of memory.
True, but that probably doesn't matter here: something's going to fail anyway
if that happens. Perhaps a wrapper is needed?
| Darren Salt | linux or ds at | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| <URL:http://www.youmustbejoking.demon.co.uk/> (PGP 2.6, GPG keys)
Nothing is ever so bad that it can't get worse.
More information about the vdr