[vdr] Key-repeat or release magic in RCU drivers

Marko Mäkelä marko.makela at hut.fi
Wed Feb 8 08:34:21 CET 2006


On Tue, Feb 07, 2006 at 11:00:23PM +0000, Darren Salt wrote:
> > If I press the same button twice within that time frame, it does happen.  I
> > must admit that this seems to happen with my own patch as well.  I'll have
> > to add some debug code to display the RC5 frames to see whether the toggle
> > bit really is toggling.
> 
> I just stuck in a printk: either it wasn't being toggled or I wasn't properly
> releasing the button. (I could probably tell, but I don't plan on opening up
> the remote control until I have to for other reasons.)

I loaded cx88xx with ir_debug=1 or something like that, and got debug output
in dmesg.  Indeed, the toggle bit did not toggle.  If this is the case with
two RCUs, then this is probably not an issue (that is, the bug is already
in the RCU).

[snip]

> > With 240 ms key-release timeout, it will time out if two RC5 frames are
> > lost.
> 
> Which seems reasonable to me, although this should perhaps be a module
> parameter with, at least, a fixed minimum value. The right place for it is in
> ir-common, but one step at a time...

Agreed.

[snip]

> > I tested patch 3326 of the hg/v4l-dvb tree with your patches
> > dvb-ir-20060206.patch.tar.gz applied.  I changed the key-release timeout in
> > cx88-input.c from 120 to 240 ms.  Few keys were recognized.  Among the
> > working keys were the number keys, although they were shifted by 1 (e.g.,
> > '6' would be reported as '7').
> 
> Oops. The last patch in that series is broken - part of it got lost. It's
> attached.

Thanks, I'll try it out after some time (hopefully, with a snapshot that
has better working cx88 drivers).

> > The input layer's own repeat handler was not disabled, that is, I think
> > there were too many repeat events. I couldn't figure out how budget-ci.c
> > disables the repeat timer.
> 
> If ir->rep[0] and ir->rep[1] are both zero then input_register_device() will
> set default delay and repeat values and install its repeat handler.

Thanks, I'll try setting those.

	Marko



More information about the vdr mailing list