[vdr] vdr 1.3.38: SVDRP grab filename

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Sat Jan 14 14:46:08 CET 2006


Stefan Huelswitt wrote:
> On 14 Jan 2006 Klaus Schmidinger <Klaus.Schmidinger at cadsoft.de> wrote:
> 
>>Stefan Huelswitt wrote:
>>
>>
>>>--- svdrp.c.orig	2005-12-30 16:42:29.000000000 +0100
>>>+++ svdrp.c	2006-01-09 19:15:51.000000000 +0100
>>>@@ -682,8 +682,7 @@
>>>      else if (strcmp(FileName, "-") == 0)
>>>         FileName = NULL;
>>>      else {
>>>-        Reply(501, "Missing filename extension in \"%s\"", FileName);
>>>-        return;
>>>+        Jpeg = true;
>>
>>This would allow overwriting files with extensions other
>>than ".jpeg", ".jpg" or ".pnm" - is this really what you want?
> 
> 
> Actualy it allows overwriting files with no extention only.
> 
> I find it convinient to be backward compatible.
> As the whole operation is limited to the grab directory anyways,
> security considerations are negligible IMHO.

And what's the point in writing to a file without an extension?

Klaus



More information about the vdr mailing list