[vdr] [PATCH] subtitles, softdevice for Shutdown rewrite for 1.5.x

Marko Mäkelä marko.makela at hut.fi
Thu Jan 25 14:33:53 CET 2007


On Sat, Jan 13, 2007 at 09:48:47PM +0100, Udo Richter wrote:
> Marko Mäkelä wrote:
> >A minor cosmetic thing: the '#' of pre-processor directives should always
> >be located at the first column of the line.  
> 
> The only indented directives are for the debug output I think, and this 
> will probably be removed before the final integration anyway.
> 
> >A more important suggestion: Could you please add a notification method
> >to status.h for notifying plugins whether VDR is currently in
> >interactive mode?  
> 
> You can poll this state on your own by calling 
> Shutdown.IsUserInactive().

I attach my patches to the subtitles and softdevice plugins.  I
intentionally kept them simple: I'm using the existing configuration
flags for disabling output.  It would be better to introduce a separate
variable for the configuration setting, and in MainThreadHook assign
the enable flag to either FALSE or the configured setting.  In that way,
the output could be permanently disabled from the plugin menus, as it
can be done now.

I'll post improved patches when the presence of the shutdown patch can
be tested with #ifdef.

	Marko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: softdevice-suspend.patch
Type: text/x-diff
Size: 1389 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/vdr/attachments/20070125/626a3cce/softdevice-suspend.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subtitles-suspend.patch
Type: text/x-diff
Size: 942 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/vdr/attachments/20070125/626a3cce/subtitles-suspend.bin


More information about the vdr mailing list