[vdr] vdr 1.5.16 - minor problem in font.c

Tobi listaccount at e-tobi.net
Fri Feb 29 01:04:17 CET 2008


Hello,

DrawText() in font.c uses the method Glyph() which may return a null pointer,
but doesn't check the returned pointer.

I came across this bug, when checking a bug report from Sven Mueller:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467512

When info.vdr contains an invalid character (like in the above example a 0xA0 -
a Latin-1 NO-BREAK SPACE),  Glyph() returns null, which then causes a segfault
when dereferencing the null-pointer.

The easiest way to fix this, would probably be to ignore such invalid
characters, which is, what the attached two-line-patch will do. But maybe it's
better to replace such characters with a default character - maybe a space or a '?'.

bye,

Tobias
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 99_invalid-char-fix.dpatch
Url: http://www.linuxtv.org/pipermail/vdr/attachments/20080229/9a38e5a2/attachment.txt 


More information about the vdr mailing list