[vdr] [PATCH v2] Gather necessary options for build in Make.global and include it.

Frank Schmirler vdr at schmirler.de
Fri Jan 29 10:04:04 CET 2010


Hi Paul,

thanks for the patch - looks good. Some suggestions from me:

1) from VDR's Makefile, remove the line
DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
It is already included from Make.global

2) in all plugin Makefiles, remove -fPIC from the line
CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual -Wno-parentheses
It will be added by Make.global anyway

3) in Make.config.template, remove only the line
DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
The lines with "+= -fPIC" are still necessary, as Make.config resets
CFLAGS/CXXFLAGS.

4) Script newplugin needs to be modified, too.

Best regards,
Frank



More information about the vdr mailing list