[vdr] [ANNOUNCE] VDR developer version 1.7.27

Dominic Evans oldmanuk at gmail.com
Wed Apr 4 23:08:19 CEST 2012


On 4 April 2012 21:48, Klaus Schmidinger <Klaus.Schmidinger at tvdr.de> wrote:
> On 04.04.2012 20:36, Dominic Evans wrote:
>> With the additional patch to fix the bug with getting a single column
>> width (that I previously mentioned), this still isn't quite working
>> correctly.
>>
>> See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
>>
>> The column has been widened, but the displayed channel names are
>> seemingly cropped to the old width?
>>
>> BBC ON rather than BBC ONE
>> BBC TW rather than BBC TWO
>> Channe rather than Channel 4
>> etc.
>
> Are you sure you're using the right version of menu.c?
> The macro CHNAMWIDTH must be used 3 times there:
>
> #> grep -n CHNAMWIDTH menu.c
>
> 52:#define CHNAMWIDTH  (Channels.MaxShortChannelNameLength() + 1)
> 1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
> CHNUMWIDTH, CHNAMWIDTH, 6, 4)
> 1614:  SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
> 1633:  SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);

Yep. Before applying my quilt series, my menu.c matches yours:

$ grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH  (Channels.MaxShortChannelNameLength() + 1)
1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
CHNUMWIDTH, CHNAMWIDTH, 6, 4)
1614:  SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1633:  SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);

After applying a few patches, the line numbers have shifted, but the
code remains the same:

$ grep -n CHNAMWIDTH menu.c
56:#define CHNAMWIDTH  (Channels.MaxShortChannelNameLength() + 1)
1550::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
CHNUMWIDTH, CHNAMWIDTH, 6, 4)
1800:  SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1819:  SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);

I can re-test with vanilla VDR sources if you think its possible they
are causing the issue?



More information about the vdr mailing list