Difference between revisions of "Development: Code Review"

From LinuxTVWiki
Jump to: navigation, search
Line 13: Line 13:
 
If you encounter a bug please file a [[Bug Report]] to the linux-dvb Mailing List or even better, send a [[Bugfix]] in unified diff format created with ''cvs -q diff -pu > patchname.diff'' to the mailing list.
 
If you encounter a bug please file a [[Bug Report]] to the linux-dvb Mailing List or even better, send a [[Bugfix]] in unified diff format created with ''cvs -q diff -pu > patchname.diff'' to the mailing list.
  
If you have a nice idea how to make things better then please start a thread on the linux-dvb Mailing List and let's discuss it.
+
When you get a nice idea how to make things better or to introduce [[Performance Optimisation]]s then please start a thread on the linux-dvb Mailing List and let's discuss it.
 +
 
 +
As soon you encounter a point where you see that it would make sense to rewrite portions of the code, to get into a deeper refactoring process, please have a look into the [[Hints for Refactoring existing DVB drivers]] section in this Wiki.

Revision as of 15:48, 27 September 2004

Definition

A Code Reviewer is somebody who looks on the source code, checks it for correctness and thinks about optimizations.


Why

Nobody is perfect, we are human too. Even today then and when a bug shows up we did not recognized before. The only way to make the linux-dvb code as stable and robust as possible is that as many developers as possible analyze the source and watch out for potential bugs and weaknesses.


When

If you encounter a bug please file a Bug Report to the linux-dvb Mailing List or even better, send a Bugfix in unified diff format created with cvs -q diff -pu > patchname.diff to the mailing list.

When you get a nice idea how to make things better or to introduce Performance Optimisations then please start a thread on the linux-dvb Mailing List and let's discuss it.

As soon you encounter a point where you see that it would make sense to rewrite portions of the code, to get into a deeper refactoring process, please have a look into the Hints for Refactoring existing DVB drivers section in this Wiki.