[linux-dvb] Re: [rfc/patch] pll handling and cx22702 update

[Johannes Stezenbach <js@linuxtv.org>]

Gerd Knorr wrote:
> > > Don't be scared because of yet another redesign, the old and new stuff
> > > can live in parallel, so can have a more smooth switchover than with
> > > the frontend refactoring ;)
> > 
> > Basically I like your approach, but your patch gets a ton of rejects
> > in cx22702.c against dvb-kernel CVS :-(
> 
> Patch is build against a pretty fresh (post-fe-refactor-merge) bk
> snapshot of the kernel, not against linuxtv cvs.  I assumed they are
> close enougth that it fits in neverless, but seems that isn't the case.
> 
> Should I just mail my current cx22702.[ch] files?  The diff likely isn't
> much smaller anyway ...

Hm, someone will have to look at the rejects anyway. The cx22702.c from
mainline kernel should probably match an older revison in CVS.

> > The improvements in code readablity are also not easy to see from your
> > patch since it mixes the PLL cleanup with a lot of other changes.
> 
> Have a look at the patch below (rdiff from video4linux cvs, 5 days ago
> against now).  That one also has some small unrelated fixes in, but the
> actual pll-related changes should be much more clear ;)

Yeah. Looks good to me.

Johannes