[linux-dvb] Re: [rfc/patch] pll handling and cx22702 update

[Andrew de Quincey <adq_dvb@lidskialf.net>]

On Saturday 18 Dec 2004 23:13, Andrew de Quincey wrote:
> Hi - sorry about not getting round to reading this earlier.
>
> I've had a quick zip though it - this looks cool - I really didn't like all
> the PLL functions floating about as they are right now... and this sorts it
> all out with the minimum of fuss and makes it much clearer what is
> happening.
>
> We can obviously extend the dvb_pll_desc structure as necessary for weird
> PLLs that require.. strange things.
>
> Everyone who replied seemed to like it - so I'm gonna start trying to
> convert the system over to it. You may see a PLL_REFACTORING branch appear
> soon. :)
>
> Not had a chance to look at the other cx22702 changes yet - I will do after
> I've sorted out the PLL stuff though.

Heres a modified version of dvb-pll.h which should allow all PLLs we have to 
be represented. WDYT?

Note that I've removed the individual PLL definitions temporarily.
/*
    DVB PLL definitions

    Copyright (C) 2004 Gerd Knorr, Andrew de Quincey

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 2 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.

*/

#ifndef DVB_PLL_H
#define DVB_PLL_H 1


struct dvb_pll_desc {

	char *name;
	void (*set) (u8 * buf, struct dvb_frontend_parameters * params);
	int init_data_size;
	u8 init_data[];
	int suspend_data_size;
	u8 suspend_data[];
	int num_entries;
	struct {
		u32 min_freq; /* inclusive */
		u32 max_freq; /* inclusive */
		u32 intermediate_freq;
		u32 stepsize;
		int data_size;
		u8 data[];
	} entries[];
};

int dvb_pll_configure(struct dvb_pll_desc *desc, u8 * buf, dvb_frontend_parameters * params);

#endif