[vdr] Re: ANNOUNCE: vdr-analogtv-0.2.0

[Rene Bredlau <murray@blubber.de>]

Hallo Klaus,

On Sun, Mar 16, 2003 at 11:26:52AM +0100, Klaus Schmidinger wrote:
> Rene Bredlau wrote:
> > 
> > Hallo Klaus,
> > 
> > On Sun, Mar 16, 2003 at 10:53:49AM +0100, Klaus Schmidinger wrote:
> > > Andreas Kool wrote:
> > > >
> > > > ...
> > > > ATTENTION:
> > > > This plugin currently requires a patch against vdr-1.1.25
> > > > This patch is in ALPHA-stage which means the "transfer-mode" of VDR does not
> > > > work very well :-(
> > > >
> > > > Finally: Please carefully read the README for installation instructions!
> > > >
> > > > You could find this plugin at:
> > > > http://akool.bei.t-online.de/vdr/download/vdr-analogtv-0.2.0.tar.bz2
> > >
> > > If I understand this correctly what you are trying to do is to implement
> > > MPEG1 capabilities into cTS2PES, since your analog source only delivers an
> > > MPEG1 Transport Stream, right?
> > >
> > > Since the existing cTS2PES used to work fine so far for MPEG2 streams, I am
> > > rather reluctant to accept a patch that goes that deep into the code, just to
> > > add MPEG1 capabilites. Could you make that modification in a away that doesn't
> > > change (and break - re. Transfer Mode) the existing (and working) MPEG2 code?
> > > The place in cTS2PES where MPEG1 is encountered is where the error message
> > > "ERROR: error in data stream!" is issued, which used to be "ERROR: can't record MPEG1!".
> > I am exaclty working on this. I am not yet finished and the plugins includes a rather old version of my patch, but we wanted to release a snapshot to show the progress of the plugin. My minimum target is to delivere a patch which is as good as the metzerler brothers code (in respect to the result).
> > 
> > In the code of the metzler code it looks like that it is the support for mpeg1 which is broken, but it is an other aspect of the mpeg stream which breaks the code. But mp1e is producing this code, and as far as i understood mpeg mp1e generates valid code. I tried to simplifie the handling of the streams (my code does not include different handling for mpeg1 and mpeg2). I have one version of the patch which delivers a perfekt image in transfermode for all broadcast i can get, but this version has problem with internal buffersizes.
> > 
> > Klaus, would you accept a patch which delivers at a minimum the same result as the original code, but add the capability for the analogtv plugin?
> 
> The less you change the original cTS2PES code the higher are your chances of
> getting it into the VDR core ;-) For instance I don't see why you need to allocate
> a _second_ buffer. Also, AFAICS you completely dropped handling of the second audio
> PID. Since this is an important core part of VDR I would prefer if you implemented
> your changes so that the original code for the MPEG2 part remains untouched as far as
> possible.
As i said bevore this is the realy first version, its mostly a proof of concept. I will give you a notice if i think i got a version which is worth to be included.

-- 
So long
	.\\urray


-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.