[vdr] Re: VDR 1.1.27 - Error: Connection to lircd lost

[Ludwig Nussel <ludwig.nussel@gmx.de>]

David Koruga wrote:
> > > i tried VDR 1.1.27 yesterday. Works great thanks a lot.
> > > But since something is changed in the Lirc handling i offten get the
> > > message:
> > > Error: Connection to lircd lost
> > 
> > Can you please run irw in a terminal, press keys on the remote and
> > post some lines of irw's output when vdr issues that message?
> 
> Thanks for the hint. While irw was running I noticed that my steering
> cross
> repeats much faster than the other buttons during my lircd.conf is
> spitted
> in "normal buttons" and "steering cross" section. I increased the
> repeat_gap
> value to 102937 like in the "normal button" section. After that change
> the Problem does not appear anymore. But shouldn't this happen even if
> the reapeat_gap value is 0?

It's a bug. The code doesn't expect a buffer that contains parts of
the next line. It ignored that previously, in 1.1.27 it's treated as
error. You may try the attached patch which makes vdr behave more
like previously (also not 100% correct).

cu
Ludwig

-- 
(o_  Ludwig.Nussel@gmx.de
//\  PGP Key ID: FF8135CE
V_/_ ICQ:        52166811


-- Attached file included as plaintext by Listar --

--- lirc.c.orig	2003-04-12 16:37:17.000000000 +0200
+++ lirc.c	2003-04-15 21:14:38.000000000 +0200
@@ -64,13 +64,14 @@
       bool ready = cFile::FileReady(f, timeout);
       int ret = ready ? safe_read(f, buf, sizeof(buf)) : -1;
 
-      if (ready) {
-         if (ret <= 21) {
-            esyslog("ERROR: lircd connection lost");
-            close(f);
-            f = -1;
-            break;
-            }
+      if (ready && ret == -1 ) {
+        esyslog("ERROR: lircd connection lost");
+        close(f);
+        f = -1;
+        break;
+        }
+
+      if (ready && ret > 21) {
          int count;
          char KeyName[LIRC_KEY_BUF];
          sscanf(buf, "%*x %x %29s", &count, KeyName); // '29' in '%29s' is LIRC_KEY_BUF-1!



-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.