[vdr] Re: VDR developer version 1.3.18

[rolf@groppe.de (Rolf Groppe)]

> VDR developer version 1.3.18 is now available at

> The changes since version 1.3.17:

Fine stuff !
After our discussion during the last days, I primarily looked at that new 
audio function. Works good. But allow me 2 remarks:
a) after selecting left or right audio, it would be better to reset that to 
stereo when changing the channel. Otherwise there there may be some 
astonishing effects.
b) There should be a possibility to call the audio menu without a remote 
audio key also if there is only 1 audio stream. In that case Menu green is 
deactivated. For me that is no problem (I have an audio key).

Also one old problem already exists for me. As I told you for 1.3.15 I have 
problems reading the keys from the pc-keyboard. They will not correctly 
recognized in case of function keys etc. which send more than one byte.
I used the following patch to solve that problem:

=== Cut ===
-+- remote.c.org    2004-10-31 15:05:12.000000000 +0100
+++ remote.c    2005-01-09 16:29:17.000000000 +0100
@@ -258,13 +258,15 @@
 }

 void cKbdRemote::Action(void)
-{
+{
+  cTimeMs zeit;
   cPoller Poller(STDIN_FILENO);
   active = true;
   while (active) {
         if (Poller.Poll(100)) {
            uint64 Command = 0;
            uint i = 0;
+           zeit.Set();
            while (active && i < sizeof(Command)) {
                  uchar ch;
                  int r = read(STDIN_FILENO, &ch, 1);
@@ -279,7 +281,7 @@
                     // of their codes, so we'll need to wait some 100ms to 
see if
                     // there is more coming up - or whether this really is 
the 'ESC'
                     // key (if somebody knows how to clean this up, please 
let me know):
-                    if (Command == 0x1B && Poller.Poll(100))
+                    if (Command == 0x1B && zeit.Elapsed() < 100)
                        continue;
                     if (Command) {
                        if (rawMode || !Put(Command)) {
=== Cut ===

Rolf