[vdr] Re: some patches for vdr-1.3.18 (SourceCaps, RO, timer-info) and plugins (femon, osdimage)

["Bauer, Bjoern" <bjoern.bauer@coremedia.com>]

new version for 1.3.18 is in cvs!

cvs -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/dvdplugin login
cvs -z3 -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/dvdplugin co dvd



-----Ursprüngliche Nachricht-----
Von: vdr-bounce@linuxtv.org [mailto:vdr-bounce@linuxtv.org] Im Auftrag von Patrick Cernko
Gesendet: Mittwoch, 12. Januar 2005 13:31
An: vdr@linuxtv.org
Betreff: [vdr] Re: some patches for vdr-1.3.18 (SourceCaps, RO, timer-info) and plugins (femon, osdimage)

Andreas Brugger wrote:
> C.Y.M wrote:
> 
>> It appears that there are a few hunks missing from your femon patch 
>> (although my diff is against 0.1.7 and yours is against 0.1.6).
>>
>> diff -ru vdr-1.3.17/PLUGINS/src/femon-0.1.7/femonreceiver.c
>> femon-0.1.7/femonreceiver.c
>> --- vdr-1.3.17/PLUGINS/src/femon-0.1.7/femonreceiver.c  2004-11-27 
>> 18:20:00.000000000 -0800
>> +++ vdr-1.3.18/PLUGINS/src/femon-0.1.7/femonreceiver.c  2005-01-10
>> 15:19:34.000000000 -0800
>> @@ -313,7 +313,7 @@
>>    //printf("cFemonReceiver::Action()\n");
>>    m_Active = true;
>>    while (m_Active) {
>> -        t0 = time_ms();
>> +        t0 = int(cTimeMs::Now());
>>          // TS packet 188 bytes - 4 byte header; MPEG standard 
>> defines 1Mbit = 1000000bit
>>          m_VideoBitrate = (8.0 * 184.0 * m_VideoPacketCount) / 
>> (femonConfig.calcinterval * 100000.0);
>>          m_VideoPacketCount = 0;
>> @@ -321,6 +321,6 @@
>>          m_AudioPacketCount = 0;
>>          m_AC3Bitrate   = (8.0 * 184.0 * m_AC3PacketCount)   / 
>> (femonConfig.calcinterval * 100.0);
>>          m_AC3PacketCount = 0;
>> -        cCondWait::SleepMs(100 * femonConfig.calcinterval - 
>> (time_ms() - t0));
>> +        cCondWait::SleepMs(100 * femonConfig.calcinterval -
>> (int(cTimeMs::Now()) - t0));
>>      }
>>  }
> 
> 

Maybe have a closer look at the code and new cTimeMs interface:

...
cTimeMs t0;
...
to.Set(); // instead of to = int(cTimeMs::Now()); ...
... t0.Elapsed() ... // instead of (int(cTimeMs::Now()) - t0)

does the same, but reads better! :-)

Just my 2 cent!

P.S.: Anyone having a patch for vdr-dvd?
--
Patrick Cernko | mailto:errror@errror.de | http://www.errror.de Quote of the Week: "Send bug-reports, fixes, enhancements, t-shirts,
                     money, beer & pizza to screen@uni-erlangen.de."
                    (screen(1) man-page)