[linux-dvb] Re: [PATCH] SS2 : Fix for OpenWholeBandWidth

[Roberto Ragusa <r.ragusa@libero.it>]

On Sun, 23 Nov 2003 20:40:18 +0100
Wolfgang Thiel <wthiel@uni-bielefeld.de> wrote:

> Doesn't this look suspicious as well:
> if (pid <= 0x1F)
>   return 1;
> Return 1 usually means success, not failure.
> This can be found in the *HW* routines.

I think it's correct.

Pids <=0x1f always pass the hardware filter because of the group/mask
filter default settings, so if they ask us to enable one of those pids
we do nothing and reply successfully.

When we OpenWholeBandwith we just expand the group/mask setting to include
every possible PID (including <=0x1f, of course), so it's OK too.

I think the 0x27 comes from 0x20 (pids <=0x1f) and 7 (single pid filters).

> 
> [ I have miserably failed to add 4:2:2 support to mplayer this weekend:
>   at least I got a first idea how mplayer is working, now :-(
> ]

Are you using the development version of libmpeg2? (4:2:2 is included)


-- 
   Roberto Ragusa    r.ragusa at libero.it


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.