[linux-dvb] Re: [PATCH] SS2 : Fix for OpenWholeBandWidth

[Roberto Ragusa <r.ragusa@libero.it>]

On Sun, 23 Nov 2003 15:26:30 +0100
Holger Waechtler <holger@convergence.de> wrote:

> > 3) to have stream1/stream2/pcr/pmt/emm/ecm specific routines, given that
> > it looks like they have no particular specialization, they're just generic
> > filters?
> 
> yes. Depending on the content it might make more sense to request 
> section-, PES- or TS-filters.

If I'm not misunderstanding the code, the skystar2 driver has some
HW filter "slots" called stream1/2/ecm... but they are used without any
specific strategy. It's just a "use the first free slot" rule.
The "if(free) use(this)" chain is ugly and pointless, IMHO. I would use
a for loop (or something better).

> yes, definitely. Can you please prepare a patch for the dvb-kernel CVS 
> tree to resolve this?

I'm not running 2.6, but I'll set up my system to check correct
compilation at least.

> Despite this the packet_header checks around line 1858 are not 
> endian-safe.

Right, that looks really bad.


-- 
   Roberto Ragusa    r.ragusa at libero.it


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.