[vdr] Re: [ANNOUNCE] calendar-0.1.0

["Jan Rieger" <vdr@ricomp.de>]

----- Original Message -----
From: "Patrick Cernko" <errror@ps.uni-sb.de>
To: <vdr@linuxtv.org>
Sent: Thursday, September 11, 2003 1:42 PM
Subject: [vdr] Re: [ANNOUNCE] calendar-0.1.0


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> > So I choosed the way to include the hole menu.c into the plugin :-(
>
> Wow, this seems pretty dangerous as all implementation in menu.c appears
> twice (in vdr itself and in your plugin). This can lead to _very_
> strange phenomenons.

I see no problem here: The names are the same - yes this is normally a
problem because the dynamic linker (wich loads the library) has to choose
one of the versions. But in fact that both versions are absolutely
identical, there should really no matter.

[...]
> Copy the declaration from vdr's menu.c to your own header file and do
> NOT include vdr's menu.c.

This is also no good idea, because of this:
If someone uses patches like Elchi-AIO, AutoPid, ... the classes could be
changed and then the definition in menu.c and the copied one doesn't
correspond to each other. That could result in wrong called methods!

I really don't know if one of these patches changes the needed classes, but
you see: it's also dangerous.

So I will not apply your patch, sorry.
Jan




-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.