[vdr] Re: final solution to the signalless operation problemfound!! -> testers+RFC required

[Andreas Oberritter <obi@linuxtv.org>]

On Wed, 2004-03-24 at 06:45, Guido Fiala wrote:
> Instead of above a more convenient solution for any kind of frontends would be 
> having the ioctl's FE_INIT and FE_SLEEP public instead of private.
> 
> I modifed vdr that it calls FE_SLEEP on opening the frontend (this could also 
> be default state in the driver itself) and if it first likes to tune with 
> this frontend it can call FE_INIT on demand and also put (unused) frontends 
> back to FE_SLEEP.

FE_SLEEP is called when the frontend handle is closed, so why does vdr
open it when it does not use it?

The only remaining problem is that the VES is in an undefined state
after insmod. So how about this patch instead?

diff -u -r1.7 ves1x93.c
--- ves1x93.c   14 Mar 2004 13:46:20 -0000      1.7
+++ ves1x93.c   24 Mar 2004 14:14:04 -0000
@@ -611,6 +611,10 @@
        state->inversion = INVERSION_OFF;
        *data = state;

+       if (board_type == BOARD_SIEMENS_PCI)
+               ves1x93_writereg(i2c, 0x1f, 0x00); /* LNB power off */
+       ves1x93_writereg(i2c, 0x00, 0x08);         /* standby */
+
        return dvb_register_frontend (ves1x93_ioctl, i2c, (void*) state,
&ves1x93_info);
 }

> Since this requires a change of the dvb-frontend-interface i like to hear some 
> comments. If it can work this way we can suggest it to the driver developers.
> 
> The advantages of this approach i see are:
> -no patching of driver required
> -it works for all frontends which tend to crash the ARM (to be tested)
> -safes power (and LNB/chip-lifetime) if frontends are not used
> -in case of a "thunderstorm" and no signal one could still watch a recording 
> without crashing if vdr puts the frontend to sleep (so it's useful not only 
> for analogtv-users)
> -just a change in frontend.h for the driver required (2 LOC's)
> -probably less than 10 LOC's of change in vdr (dvbdevice.c) required

close() has the same advantages without changing any interface.

Regards,
Andreas



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.