[vdr] Re: PATCHES: vdr-1.2.6 (getSTC and mp2)

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Sven Goethel wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Sunday 02 November 2003 21:12, Klaus Schmidinger wrote:
> > Sven Goethel wrote:
> > > dear KLAUS,
> > >
> > > i now use the getSTC function in:
> > >         - vdr-dvd
> > >         - bitstreamout
> > >
> > > and the mp2-playAudio audio stuff with:
> > >         - bitstreamout
> > >
> > > it would be very kind of you, if you can apply those patches
> > > in the very next version
> >
> > I haven't had much time for VDR lately, so I wasn't
> > able to look into this too deeply. I definitely won't add this to 1.2.6,
> > as I already wanted to finish the 1.2 line with 1.2.5 ,-) and get on
> > with new stuff in 1.3. That's where I'll add this.
> >
> > However, what I don't like about your patch is that cDvbDevice::GetSTC()
> > actively adds a PID - that's something a cReceiver should do if it needs
> > it.
> 
> for real - just ptPcr, if its not allready added
> (and internally - as far as i read - it should anyway for sync ..)

Oh, I see (sorry, just briefly looked over the patch and saw that
there is a PID set where I didn't expect it).

So what do you need this PCR-PID setting for, anyway?
After all, in live mode cDvbDevice::SetChannelDevice() does set the
PCR PID - or am I missing something here?

> i used the pid type (audio/video/Pcr) paradigma,
> just because of some convinient and semantic usage.
> 
> but if you like to use another way .. whatever .. since it is
> convinient - at least the ptPcr should be available -
> its ok for me - change it.
> 
> but i would love to bring this asap into it, to save users from
> patching vdr .. for those two plugins ..
> just my humble opinion ;-)

If it's just about adding GetSTC() I might consider this for 1.2.6,
but then the setting of the PCR PID has to be dropped since that one
is already set - or is there a situation where this isn't the case?.

Also, what's with the 'ePidType type=ptPcr' parameter in GetSTC()?
Is this to be called with other 'type's, too?

Sorry if my questions seem dumb to you, but I currently
don't have the time to look deeper into this, so you'll need to
explain to me very detailed what and why you do it ;-) After all,
version 1.2.6 is almost about to be released, so I can't add
anything that might have unwanted side effects.

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.