[vdr] [FINAL TESTING]: text2skin 1.0-rc1

[Jouni Karvo <jouni.karvo@tkk.fi>]

hello,

Sascha Volkenandt writes:
 > 
 > The Plugin contains a script contrib/skin_to_10.pl, which can help convert an 
 > old skin to the new format. But the result will be erroneous and far from 
 > perfect! Please refer to the three demo skins, the documentation included in 
 > the Docs directory, or the vdr-wiki how to correct those errors. Text2Skin 
 > should print in the syslog what went wrong and where it happened.

well, there is something missing in the error handling:

Using an old skin first writes this to user.log:

Jan  6 18:35:32 vdr vdr[23206]: ERROR: text2skin: Skin is version ,
expecting 1.0

then VDR segfaults:

gdb --core core.11737 ./vdr-prod
bt
#0  std::string::compare (this=0xfffffffc, __s=0xb7b2f750 "text")
    at
/home/kex/installs/compiling/gcc-3.2.3/i686-pc-linux-gnu/libstdc++-v3/include/bits/basic_string.h:229
#1  0xb7b22d3f in xCharData () from
./PLUGINS/lib/libvdr-text2skin.so.1.3.17
#2  0xb7b2b885 in XML::readChar () from
./PLUGINS/lib/libvdr-text2skin.so.1.3.17
#3  0xb7b2b36e in XML::parse () from
./PLUGINS/lib/libvdr-text2skin.so.1.3.17
#4  0xb7b232b9 in xmlParse () from
./PLUGINS/lib/libvdr-text2skin.so.1.3.17
#5  0xb7b03cae in cText2SkinLoader::Load () from
./PLUGINS/lib/libvdr-text2skin.so.1.3.17
#6  0xb7b03716 in cText2SkinLoader::Start () from
./PLUGINS/lib/libvdr-text2skin.so.1.3.17
#7  0xb7b0340e in cText2SkinPlugin::Start () from
./PLUGINS/lib/libvdr-text2skin.so.1.3.17
#8  0x080bc7fc in cPluginManager::StartPlugins (this=0xbffffab0) at
plugin.c:326
#9  0x080e0c06 in main (argc=136824072, argv=0x0) at vdr.c:462
(gdb) 

yours,
		Jouni