[linux-dvb] Re: [PATCH] Ultra Light Encapsulation

[Hilmar Linder <hlinder@cosy.sbg.ac.at>]

Hi Johannes,
> > > > +#define FEEDTYPE_SEC    0
> > > > +#define FEEDTYPE_TS        1
>
> I think these #defines are rather obscure. Why not rename
> them to DVB_NET_FEED_MPE and DVB_NET_FEED_ULE?
We have choosen FEEDTYPE_TS and FEEDTYPE_SEC because ULE reassembles the 
IP packets directly from the TS while MPE reassembles the packets from 
Sections. If there would be another new encapsulation (e.g. on TS level) 
one would need no additional defines. However, if you want to rename 
them, we are fine.
>
> I haven't checked, but the size of struct dvb_net_if is encoded
> into the ioctl number, so to maintain binary backward compatibility
> we need to add a struct dvb_net_if_old and NET_ADD_IF_OLD/NET_GET_IF_OLD
> (similar to the VIDIOC_*_OLD in videodev2.h), and proper support
> in dvb_net.c. Then old binaries would work with the new driver.
Sounds like a good idea.

Regards,

-Hilmar


--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.