[linux-dvb] Re: Problems with Twinhan USB / Problem identified:SMP

[Patrick Boettcher <patrick.boettcher@desy.de>]

On Tue, 26 Oct 2004, Philipp Stucke wrote:

Hi Philipp,

> Call Trace:
>  [<c0104d9a>] show_stack+0x7a/0x90
>  [<c0104f22>] show_registers+0x152/0x1d0
>  [<c0105130>] die+0xf0/0x180
>  [<c01055e4>] do_invalid_op+0xd4/0xf0
>  [<c0104a1d>] error_code+0x2d/0x38
>  [<e09d7434>] dibusb_get_free_pid+0x14/0x60 [dvb_dibusb]
>  [<e09d77d7>] dibusb_start_feed+0x27/0x90 [dvb_dibusb]

OK, this is where I use the spinlock actually.

But I'm not clever enough to understand this.

Maybe you could try the attached patch, please, I forgot to initialize the
spinlock.


Patrick.

--
  Mail: patrick.boettcher@desy.de
  WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/
Index: dvb-dibusb.c
===================================================================
RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/dibusb/dvb-dibusb.c,v
retrieving revision 1.10
diff -u -r1.10 dvb-dibusb.c
--- dvb-dibusb.c	4 Oct 2004 09:12:20 -0000	1.10
+++ dvb-dibusb.c	26 Oct 2004 10:28:20 -0000
@@ -548,6 +548,7 @@
 		}
 	}
 	
+	dib->pid_list_lock = SPIN_LOCK_UNLOCKED;
 	for (i=0; i < DIBUSB_MAX_PIDS; i++) {
 		dib->pid_list[i].reg = i+DIB3000MB_REG_FIRST_PID;
 		dib->pid_list[i].pid = 0;