[linux-dvb] Re: FE_REFACTORING move to HEAD time?

["C.Y.M" <syphir@syphir.sytes.net>]

Andrew de Quincey wrote:
> On Tuesday 26 Oct 2004 22:19, C.Y.M wrote:
>
> > Holger Waechtler wrote:
> >
> > > Michael Hunold wrote:
> > >
> > > > Hi,
> > > >
> > > > On 10/26/04 18:57, Andrew de Quincey schrieb:
> > > >
> > > > > Hi - I've not seen any major problems with the new codebase, and I've
> > > > > not made any major changes (apart from adding support for new cards)
> > > > > for a while. Admittedly there are still a few unsupported obscure
> > > > > cards, but until I know the details of them they cannot be supported.
> > > > > IMO the quickest way to get this information is to stop them from
> > > > > working - people will tell us quickly enough :)
> > > > >
> > > > >
> > > > >
> > > > > I was thinking it was about time to move it to HEAD. WDYT?
> > > > That's fine by me. Just go ahead.
> > > >
> > > > I've nearly finished my next patchset for Andrew Morton. It would be
> > > > cool if the refactoring of the frontends can be submitted in the near
> > > > future.
> > > yes, sounds good.
> > >
> > > Holger
> > What kernel version are you guys testing this "refactored" branch with?
> > Will it compile with 2.6.10-rc1?  Also, does this change only affect the
> > frontend or will the drivers need alteration as well?
>
> It affects all the dvb code. But all the changes (barring conflicts with 
> changes to HEAD) are done.
>
> I'm using 2.6.9-rc2 I think - but when I merge them I'll test with that and 
> the very latest rc release.
>
> OK - so let's say Thursday at 12 noon GMT. I'll mail the list 10 minutes 
> before beginning to "advisory lock" dvb-kernel CVS.
Thanks for all your hard work.  There are just a few patches that I 
apply to the drivers when I build them for NTSC.  I hope these patches 
will still apply ok to the new "refactored" branch:

1) Change the default to NTSC so we dont see "scrolling" when flipping 
b/n channels:

--- dvb-kernel/linux/drivers/media/dvb/ttpci/av7110_av.c.old 
2004-03-23 09:56:53.000000000 -0800
+++ dvb-kernel/linux/drivers/media/dvb/ttpci/av7110_av.c 
2004-05-04 01:58:45.000000000 -0700
@@ -1424,7 +1424,7 @@

 int av7110_av_init(struct av7110 *av7110)
 {
-       av7110->vidmode = VIDEO_MODE_PAL;
+       av7110->vidmode = VIDEO_MODE_NTSC;

        av7110_ipack_init(&av7110->ipack[0], IPACKS, play_audio_cb);
        av7110->ipack[0].data = (void *) av7110;

2) Change the permissions so the remote control can be executed as a 
non-root user (for VDR's remote plugin to work properly):

diff -ru dvb-kernel/linux/drivers/media/dvb/ttpci/av7110_ir.c 
/usr/src/Linux-DVB.CVS/dvb-kernel/linux/drivers/media/dvb/ttpci/av7110_ir.c
--- dvb-kernel/linux/drivers/media/dvb/ttpci/av7110_ir.c.old 
2004-05-03 09:29:28.000000000 -0700
+++ dvb-kernel/linux/drivers/media/dvb/ttpci/av7110_ir.c 
2004-05-04 01:58:45.000000000 -0700
@@ -181,7 +181,7 @@
        av7110_setup_irc_config(NULL, 0x0001);
        av7110_register_irc_handler(av7110_emit_key);

-       e = create_proc_entry("av7110_ir", S_IFREG | S_IRUGO | S_IWUSR, 
NULL);
+       e = create_proc_entry("av7110_ir", S_IFREG | S_IRUGO | S_IWUGO, 
NULL);
        if (e) {
                e->write_proc = av7110_ir_write_proc;
                e->size = 4 + 256 * sizeof(u16);

3)  Disable the default frontend timeout so we dont get a blackscreen 
after a while:

diff -ru dvb-kernel/linux/drivers/media/dvb/dvb-core/dvb_frontend.c 
/usr/src/Linux-DVB.CVS/dvb-kernel/linux/drivers/media/dvb/dvb-core/dvb_frontend.c
--- dvb-kernel/linux/drivers/media/dvb/dvb-core/dvb_frontend.c.old 
2004-05-03 09:29:27.000000000 -0700
+++ dvb-kernel/linux/drivers/media/dvb/dvb-core/dvb_frontend.c 
2004-05-04 01:58:45.000000000 -0700
@@ -41,7 +41,7 @@
 #include "dvbdev.h"

 static int dvb_frontend_debug;
-static int dvb_shutdown_timeout = 5;
+static int dvb_shutdown_timeout = 0;
 static int dvb_override_frequency_bending;
 static int dvb_force_auto_inversion;
 static int dvb_override_tune_delay;