Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[vdr] Re: cMenuEditStrItem does not work if no Tab is set



I demand that Sascha Volkenandt may or may not have written...

[snip]
> All Skins I currently know (including text2skin-1.0-rc1) draw into the next
> tab if the text in one tab is too long and the next tab is empty. [...]

That's useful (presuming that you mean "next field"). Presumably, they all
truncate the text if the next field is *not* empty or if they'd otherwise
render past the right-hand edge of the OSD area...

... and indeed the supplied skins do truncate the text if the next field
isn't empty.

Klaus - it'd be useful if you'd apply the following patch, or something
similar:

--- vdr-1.3.17/menu.c
+++ vdr-1.3.17/menu.c
@@ -969,7 +969,7 @@
   char t = Timers.GetMatch(Event, &TimerMatch) ? (TimerMatch == tmFull) ? 'T' : 't' : ' ';
   char v = event->Vps() && (event->Vps() - event->StartTime()) ? 'V' : ' ';
   char r = event->IsRunning() ? '*' : ' ';
-  asprintf(&buffer, "%d\t%.*s\t%s\t%c%c%c\t%s", channel->Number(), 6, channel->ShortName(true), event->GetTimeString(), t, v, r, event->Title());
+  asprintf(&buffer, "%d\t%s\t%s\t%c%c%c\t%s", channel->Number(), channel->ShortName(true), event->GetTimeString(), t, v, r, event->Title());
   SetText(buffer, false);
 }
 

This fixes a small problem with channel names in the now/next display: six
characters is nowhere near enough. Consider "BBC Ra" against "BBC Radio "
(with enAIO applied - incidentally, that patch will need similar
modification) and "BBC Radio 1", "BBC Radio 2" etc.

Many of the UK DVB-T channels have names which are unique in the first six
characters. A few more - but not all - are unique in the first ten. With this
limit removed, or at least significantly increased, they're all identifiable.

-- 
| Darren Salt | nr. Ashington, | d youmustbejoking,demon,co,uk
| Debian,     | Northumberland | s zap,tartarus,org
| RISC OS     | Toon Army      | @                      Say NO to UK ID cards
|                                                       http://www.no2id.net/

It is difficult to prophesy, especially about the future.




Home | Main Index | Thread Index